Hi, I am wondering about the state of the "fedora-review" package. It seems to be a pretty important package to ensure new stuff adhers to the latest Fedora packaging policy.
When I ran "fedora-review" I noticed that it was clearly not updated for some time: There where outdated points about bundled libraries (nowadays without special FPC exception), a warning about an unnecessary "gcc" build requirement and many outdated links. Well, it turns out fedora-review fails to build from source since July 2018 [3] (last successful koji build was in March 2018). I think at least some things are fixed upstream [4] but the RPM package was never updated. Is fedora-review still the preferred tool to do package reviews? Background: In the last weeks I spent a bit of time checking the review requests for hcc [1] and hip [2] which form an important part of AMD's "rocm" stack. These packages are "special snowflakes" in a sense that they are compilers/compiler wrappers with all the shenanigans this involves (bundled llvm, explicit lib dependencies, even dependencies on static libraries). Approving these libraries would require ignoring quite a few rpmlint errors/warnings and I don't feel confident in doing so if the fedora-review tool is obviously outdated. (Btw: I'd highly appreciate if someone could look at the hcc/hip review requests. These packages would enable "open source machine learning" in Fedora and IMHO that area fits Fedora's mission pretty well.) Thank you very much, Felix [1] https://bugzilla.redhat.com/show_bug.cgi?id=1545479 [2] https://bugzilla.redhat.com/show_bug.cgi?id=1668010 [3] https://bugzilla.redhat.com/show_bug.cgi?id=1603956 [4] https://pagure.io/FedoraReview _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
