Hi,
On Tue, 8 Oct 2019 at 12:58, <notificati...@fedoraproject.org> wrote:
> Notification time stamped 2019-10-08 11:54:56 UTC
>
> From 26d638db91fa316f706ea947ab076bce216ec8cc Mon Sep 17 00:00:00 2001
> From: Phil Sutter <psut...@redhat.com>
> Date: Oct 08 2019 11:51:27 +0000
> Subject: iproute-5.3.0-2
>
>
> - ifcfg script uses killall, therefore requires psmisc package
>
IMO that fix is fundamentally wrong.
Instead using killall it should be used systemd to reload service
("systenctrl reload rdisc").
Why? In case of using LXC or other containerisation ifcfg which will be
using killal and used from global zone/namespace will cause to reload
all rdisc (those running in containers as well).
Next is that rdisc is part of the iputils which is not listed in list of
iproure dependencies (I'm not sure is it correct to add that dependency but
seems it is legit).
Other thing is that ifcfg script is bash dependent because
$ grep -w local /usr/sbin/ifcfg
local sbase fwd
local class;
Those two lines can be removed without harming anything to make that script
full POSIX sh compliant (and still working correctly with bash as
/usr/bin/sh).
BTW. Looks like no one in Fedora have been looking on all cases like above
to have proper separation between zones/container/namespaces.
kloczek
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
