On Mon, 2021-02-15 at 11:50 +0100, Vít Ondruch wrote: > Dne 14. 02. 21 v 19:45 Kevin Fenzi napsal(a): > > So, I am a bit leary of this change for the same reason that I was for > > the last few changes like this. Namely, we are building out own layer on > > top of rpm to make our lives easier, when we probibly should try and > > just improve rpm to do this for everyone. > > > > I realize that rpm is slow to move and this might not be practical, but > > I sure wish we would try. > > > > As a strawman, what about this that upstream might take: > > > > * keep the same macros you propose (don't care what colour the bikeshed > > is) > > * src.rpms grow a (optional) releases (or whatever) dir. > > * under this (optional) dir we have a subdir for each version. > > * under that (optional) dir we have a subdir for each release. > > * under that (optional) dir we have files for changelogs. > > > Just FTR, when I was proposing some macros to include Changelog into RPM, I > was told that one of benefits of RPM and > spec file is that it is all together in one file: > > https://github.com/rpm-software-management/rpm/issues/393#issuecomment-365181602 I rather agree with that - I did some Debian packaging in the past and the bunch of random folder trees containing almost random files that stands in for the spec file in Deb packages was pretty scary for me as a packaging beginner.
Having everything in a single file really helps to see what a package is about without having to dig through a million files, not to mention makes comparing package revision easy. I guess having changelog in one separate file is still bearable in this context, but would I hope it does not start a splitting trend where other parts of the spec file get randomly split out as well. > > If you look at the problem from this angle, then I can't see how this would > be acceptable to RPM upstream :/ > > > > Vít > > > > > So, the last few ansible builds would have: > > > > ansible-2.9.17-1.fc34: > > > > ansible/releases/2.9.17/1/update-to-2.9.17 > > ansible/releases/2.9.16/2/conflict-with-ansible-base > > ansible/releases/2.9.16/2/Adjust-collections-generator > > ansible/releases/2.9.16/1/update-to-2.9.16 > > ... > > > > When building, rpm would sort the releases dir, then the version subdir, > > then concat the changelog fragments into a changelog. This way > > everything is in the src.rpm. > > > > When doing a PR, you would make a new version subdir and > > put a changelog fragment in it and commit it with any of > > your other changes. > > > > Probibly some problems with that, but I thought I would throw it out > > there from my sleep deprived mind. :) > > > > Anyhow, I just am a bit leary of us building up more and more around > > rpm, and not just fixing rpm. > > > > kevin > > > > > > _______________________________________________ > > devel mailing list -- devel@lists.fedoraproject.org > > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > > Fedora Code of Conduct: > > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > > List Archives: > > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > > Do not reply to spam on the list, report it: > > https://pagure.io/fedora-infrastructure > > _______________________________________________ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > Do not reply to spam on the list, report it: > https://pagure.io/fedora-infrastructure _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
