On Tue, Mar 02, 2021 at 08:26:31AM -0800, Adam Williamson wrote:
> On Tue, 2021-03-02 at 13:59 +0000, Richard W.M. Jones wrote:
> >
> > Other tests are kind of random. I mean, what does this mean?
> >
> > https://osci-jenkins-1.ci.fedoraproject.org/job/fedora-ci/job/rpminspect-pipeline/job/master/12861/testReport/(root)/tests/
> >
> > Stuff like:
> >
> > 1) File /usr/lib64/ocaml/cmdliner/cmdliner.a changed content on x86_64.
> >
> > Amazing! The package was rebuilt, what did you expect?
>
> The test description does explain this to some extent:
> "Report changed files from the before build to the after build.
> Certain file changes will raise additional warnings if the concern is
> more critical than just reporting changes (e.g., a suspected security
> impact)."
> I suspect the types of files that changed here are flagged as being
> "critical" on the basis that they are effectively ABI, so this is
> telling you more or less the same thing as the abidiff failure: the
> update changes the ABI. Note that many other files in the package will
> have changed, but they're not *all* shown in the test results, just
> these specific ones.
>
> The question here is more "should ABI change-type issues be counted as
> failures on Rawhide 'updates'?", I think.
For OCaml packages this isn't especially relevant. The *.a files are
just a convenient format to ship compiled OCaml code, which won't make
much sense to abidiff-type tooling.
$ nm /usr/lib64/ocaml/cmdliner/cmdliner.a | head -20
cmdliner_trie.o:
0000000000000010 r caml_absf_mask
U caml_alloc1
U caml_call_gc
U caml_c_call
0000000000000170 D camlCmdliner_trie
0000000000000228 D camlCmdliner_trie__1
0000000000000158 d camlCmdliner_trie__10
0000000000000138 d camlCmdliner_trie__11
0000000000000120 d camlCmdliner_trie__12
0000000000000100 d camlCmdliner_trie__13
00000000000000e0 d camlCmdliner_trie__14
00000000000000c0 d camlCmdliner_trie__15
00000000000000a0 d camlCmdliner_trie__16
0000000000000208 d camlCmdliner_trie__2
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html
_______________________________________________
devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
