On 28/12/2021 13:17, Neal Gompa wrote:
It is. There are plenty of packages that compile for tests. I have
one, for example (libeconf).

I think all compilation should be done in %build.

Why? If the package is being maintained as a single spec across
multiple branches, you'd have to ask them to condition it, which is
hard to do. Removing it would break it for packagers maintaining a
single spec across branches, all for avoiding a redundant call. It'd
be better to advise packagers to only use this for older Fedora and
EPEL and let them fix it.

I agree. I think %set_build_flags can be removed after Fedora 35 reaches EOL.

--
Sincerely,
  Vitaly Zaitsev (vit...@easycoding.org)
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to