* Aleksei Bavshin: > On 12/1/22 23:18, Aleksei Bavshin wrote: >> On 12/1/22 22:28, Florian Weimer wrote: >>> I don't see what spec file aspect is causing this failure: >>> >>> $ fedpkg clone -a cups-bjnp >>> Cloning into 'cups-bjnp'... >>> remote: Enumerating objects: 278, done. >>> remote: Counting objects: 100% (278/278), done. >>> remote: Compressing objects: 100% (222/222), done. >>> remote: Total 278 (delta 112), reused 96 (delta 47), pack-reused 0 >>> Receiving objects: 100% (278/278), 158.64 KiB | 752.00 KiB/s, done. >>> Resolving deltas: 100% (112/112), done. >>> $ cd cups-bjnp >>> $ fedpkg srpm >>> Not downloading unused cups-bjnp-2.0.3.tar.gz >>> >>> setting SOURCE_DATE_EPOCH=1669852800 >>> error: Bad file: /home/fweimer/cups-bjnp/cups-bjnp-2.0.3.tar.gz: No >>> such file or directory >>> >>> RPM build errors: >>> Bad file: /home/fweimer/cups-bjnp/cups-bjnp-2.0.3.tar.gz: No >>> such file or directory >>> Could not execute srpm: Failed to execute command. >>> >>> fedpkg-simple doesn't have this problem (presumably because it downloads >>> whatever is in the sources file, whether used or not), so the package >>> builds fine in Koji. >>> >>> Any ideas? >> Difference in opinions on specfile syntax :) >> This is the regex rpkg uses to find the source/patch tags: >> r'^((source[0-9]*|patch[0-9]*)\s*:\s*(?P<val>.*))\s*$'[1] > > Actually, > > r'^((source[0-9]*|patch[0-9]*):\s*(?P<val>.*))\s*$', > > The line in my message was something I modified to test the hypothesis. > >> As you can see, it does not expect spaces between Source[0-9]* and >> ':'. >> rpm, however, allows the spaces and there's 6 packages in Fedora >> that use this syntax quirk. >> [1]: https://pagure.io/rpkg/blob/master/f/pyrpkg/spec.py#_18
Thanks, this certainly explains it. Should I submitt a pull request for pyrpkg to use your first variant of the regexp? Or how should we deal with this? Florian _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
