Ron Olson <tachokni...@gmail.com> writes: > Hey all- > > I commented out a SOURCES line in a spec file to test something and got an > interesting warning: “Macro expanded in comment on line …”. I assume it’s > just that, a warning, but was kinda surprised to see a commented-out line > being evaluated at all. I did some searching and came across this BZ from > 2015: https://bugzilla.redhat.com/show_bug.cgi?id=1224660 that seems to > suggest there’s a better way (%dnl), so if I want to comment something out > instead of putting a # in front of the line, I should use %dnl?
Yes, # does not prevent macro expansion, all it does is that # is prepended to the expanded macro before it is being fed to the shell. For single line macros, that is equivalent to commenting it out, but for macros that expand to multiple lines, you'll get *very* interesting errors. And macros which have side effects will still have that side effect. %dnl on the other hand will (iirc) instruct RPM to not expand anything after it on this line. Cheers, Dan _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
