On 06-05-2023 19:26, Globe Trotter via devel wrote:
The reason stapler was published as pdf-stapler was that there was then a package called stapler on Fedora, so it was suggested to me that I use pdf-stapler, which is any case better because it emphasizes that the software is for pdfs. However, the name stapler itself is quite meaningless but upstream did not buy my argument:-( Perhaps we call it python-pdf-stapler?
I see. Whatever provided /usr/bin/stapler has gone. However, I jumped to conclusions a bit too soon. It seems the package could do with some clean up in general. But that's not for you, but for upstream. E.g. the test stuff is not separate from the sources and thus installed along with the module.
I will look into making use of the Python macros. Hopefully it is not problematic, because I am still not all that familliar with the process. Thanks!
I put in a PR changing the spec file to use the new Python macros as well as fixing some (minor) issues. See it as a starting point. Feel free to ask in the PR if anything is unclear.
I'm coming back on the renaming discussion. As Ben stated:
You could make a case for renaming the python3-staplelib subpackage to python3-staple, adding the appropriate Obsoletes[2], and adding %py_provides python3-staplelib
I saw that the installed module is in fact called 'staplelib', while the package on PyPI is called 'stapler'. In that regard I don't see a need to rename at all and there are reasons why the package is named 'pdf-stapler'.
If at all, you could add '%py_provides python3-stapler' to align it with PyPI.
-- Sandro _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
