On Tue, Sep 3, 2024 at 1:50 PM Richard W.M. Jones <rjo...@redhat.com> wrote: > > On Sun, Sep 01, 2024 at 09:54:38PM +0000, Dridi Boukelmoune wrote: > > On Sun, Sep 1, 2024 at 9:40 PM Dridi Boukelmoune > > <dridi.boukelmo...@gmail.com> wrote: > > > > > > > > I can't say I'm proud of this hack but at least, the error message > > > > > shows up to give a clue. I can finally add some error handling to my > > > > > dependency generators. > > > > > > > > Yes, currently the exit code is ignored, and the only way to break the > > > > build is to generate a line that does not parse as a valid RPM > > > > dependency. > > > > > > > > The Rust dependency generator does something similar, and the Python > > > > generator does too, AFAIK. > > > > > > And with that, I'm no longer feeling guilty, thanks! > > > > And I found prior art to follow: > > > > https://pagure.io/fedora-rust/cargo2rpm/blob/0dc93154e0cb9c27d9f255223c5b89c71259ea76/f/cargo2rpm/__main__.py#_10-18 > > Here are a few more dependency generators that have been in use for > years that you might take inspiration from: > > https://src.fedoraproject.org/rpms/nbdkit/blob/rawhide/f/nbdkit-find-provides > https://src.fedoraproject.org/rpms/nbdkit/blob/rawhide/f/nbdkit.attr > > https://src.fedoraproject.org/rpms/supermin/blob/rawhide/f/supermin-find-requires > https://src.fedoraproject.org/rpms/supermin/blob/rawhide/f/supermin.attr > > https://github.com/rpm-software-management/rpm/blob/master/scripts/ocamldeps.sh > https://github.com/rpm-software-management/rpm/blob/master/fileattrs/ocaml.attr
Thanks! > I do see a few 'exit 1' in those :-( I will have a look and open tickets if appropriate. Not sure when, I will soon run out of a big chunk of spare time. Dridi -- _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
