On Tue, Jun 3, 2025 at 10:18 AM Petr Pisar <ppi...@redhat.com> wrote: > > V Mon, Jun 02, 2025 at 09:40:55PM +0100, Aoife Moloney via devel-announce > napsal(a): > > The proposed macros for adding new flags are: > > > > %_pkg_extra_cflags > > %_pkg_extra_cxxflags > > %_pkg_extra_fflags > > %_pkg_extra_ldflags > > > Does the leading underscore have any purpose? AFAIK RPM maintainer reserves it > for RPM internal purposes.
I followed 1) The original commit of the old Fedora change, which got accepted into the redhat-rpm-config package which I take as a sign from the redhat-rpm-config package maintainers saying "This was acceptable both from implementation POV and style / naming POV few years back, so it will likely be today." 2) The `buildflags.md` documentation file in which all of the flags for manipulating specific parts of the flags start with an underscore. https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/rawhide/f/buildflags.md I'm open to changing it to whatever will work for the maintainer(s) of 'redhat-rpm-config'. If it will end up with a different name or format, I will update this proposal and the resulting documentation accordingly. I seek the new functionality, the precise name of the macro is an implementation detail from my POV. > > These will be added to %{build_cflags}, %{build_cxxflags}, > > %{build_fflags}, and %{build_ldflags} respectively to allow packages > > to add their own flags to the default list: e.g. > > > > %build_cflags %{optflags} %{_pkg_extra_cflags} > > > [...] > > ** The > > https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/rawhide/f/buildflags.md > > will be updated to document this macro > > Please document there what "added" means. I guess appended without any attempt > for deduplication of already present options. Both addition to the code and to the `buildflags.md` documentation file is planned to be done as an append to existing code / text. I'm not planning on removing anything. Also, before I proposed this change, I discussed the ways to achieve my goal with the existing options, and I found none. So I already believe there is little to no room for deduplication. Michal -- Michal Schorm Software Engineer Databases Team Red Hat -- On Tue, Jun 3, 2025 at 10:18 AM Petr Pisar <ppi...@redhat.com> wrote: > > V Mon, Jun 02, 2025 at 09:40:55PM +0100, Aoife Moloney via devel-announce > napsal(a): > > The proposed macros for adding new flags are: > > > > %_pkg_extra_cflags > > %_pkg_extra_cxxflags > > %_pkg_extra_fflags > > %_pkg_extra_ldflags > > > Does the leading underscore have any purpose? AFAIK RPM maintainer reserves it > for RPM internal purposes. > > > These will be added to %{build_cflags}, %{build_cxxflags}, > > %{build_fflags}, and %{build_ldflags} respectively to allow packages > > to add their own flags to the default list: e.g. > > > > %build_cflags %{optflags} %{_pkg_extra_cflags} > > > [...] > > ** The > > https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/rawhide/f/buildflags.md > > will be updated to document this macro > > Please document there what "added" means. I guess appended without any attempt > for deduplication of already present options. > > -- Petr > -- > _______________________________________________ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > Do not reply to spam, report it: > https://pagure.io/fedora-infrastructure/new_issue -- _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
