On 2025-10-21 6:50 AM, Panu Matilainen wrote:
If that's the case, then I think we'll need two steps to clean up:

1: replace all of the uses of %limit_build and %constrain build, then..

2: replace the %limit_build and %constrain_build macro definitions with versions that consume the -m and -c arguments, but return nothing and have no side effects

(and maybe 3: announce the deprecation of those macros somewhere)

Or just make these macros wrappers that do (roughly) the same thing using the rpm native things. That'd allow folks to keep it compatible across multiple distro versions, as I imagine some users like Firefox might want.


I think that if we redefined them to set _smp_tasksize_proc, we could use SUSE's specs, but not the reverse (as far as I know, they don't have %constrain_build, and their %limit_build does a different thing). So, I think we should definitely start by eliminating as many uses as possible. I opened a bunch of PRs to replace most of them, and: https://bugzilla.redhat.com/show_bug.cgi?id=2404624

One maintainer said that they'd like consensus on that bug, so if you want to chime in there, it might help get the remaining PRs merged.

-- 
_______________________________________________
devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to