On Mon, 2011-08-01 at 19:08 +0100, Richard Hughes wrote: > On 1 August 2011 15:24, Jaroslav Reznik <jrez...@redhat.com> wrote: > > It's not very good idea to ship pre-generated moc files, better to > > autogenerate them during the build-time. PackageKit is using automake, > > so it's a little bit more difficult but possible, check for example [1]. > > Right, I *think* I'm doing the right thing in > https://gitorious.org/packagekit/packagekit/blobs/master/lib/packagekit-qt/src/Makefile.am > with the only difference being that I'm shipping the moc files in the > tarball. Can I just nuke the moc files in the fedora spec file, and > they'll get regenerated at build time? Or should I remove MOCFILES > from EXTRA_DIST?
I'm no authority on qt/kde, but the original issue seems to indicate that moc files should be generated during compilation time (i.e. shouldn't be shipped in the tarball). Other than increasing compilation time, this shouldn't be an issue as moc is part of qt-devel. Nils -- Nils Philippsen "Those who would give up Essential Liberty to purchase Red Hat a little Temporary Safety, deserve neither Liberty n...@redhat.com nor Safety." -- Benjamin Franklin, 1759 PGP fingerprint: C4A8 9474 5C4C ADE3 2B8F 656D 47D8 9B65 6951 3011 -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
