Ok I realise it is not a good idea. I will reimplement it and send an
other review :-)
Thanks for all your feedbacks.
thierry
On 10/30/2013 08:11 PM, Rich Megginson wrote:
On 10/30/2013 12:56 PM, Jan Rusnacko wrote:
Hello Thierry,
layout OK.
As for tests - instead of reinventing the wheel by defing class
Test_standAlone
to set up instance, use py.test fixture.
+1
Also, you should not force setup, test, teardown execution for each
test by
specifying sub-methods for each test. Testing framework (py.test)
should be
doing that. I think this will make your tests fail badly if some
exception
occurs - if _test_ticket47560_setup raises exception, it will
propagate back to
py.test and cleanup method will never be executed for that ticket.
+1
Also, I believe each ticket should have its own file which contains
one or more
testcases. I think that would reasonably group relevant things together.
+1
On 10/30/2013 05:57 PM, thierry bordaz wrote:
https://fedorahosted.org/389/attachment/ticket/47578/0001-Ticket-47578-CI-tests-removal-of-sudo-and-absolute-p.patch
--
389-devel mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/389-devel
--
389-devel mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/389-devel
--
389-devel mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/389-devel
