See 3/3 for in depth explanation.
After this, there's still one problem - the ssh transport (tcp+ssh://...)
because virNetSocketNewConnectSSH() does not really ask for
virConnectAuthCallbackPtr. There should be a way to fix it though: from
bash script parse URI and append ?no_tty=1 at the end of URI. This
directs virNetSocketNewConnectSSH() to execute SSH binary with
BatchMode=yes which is documented to suppress keyboard interaction.

If we find this ^^ needed I can try to write a patch. But for now, let's
fix other transports.

Michal Prívozník (3):
  virnetsshsession: Don't check for auth callbacks in
    virNetSSHAuthenticatePassword()
  virnetlibsshsession: Check later for auth callback in
    virNetLibsshAuthenticatePassword()
  virsh: Provide no auth callbacks for bash completer

 src/rpc/virnetlibsshsession.c | 14 +++++++-------
 src/rpc/virnetsshsession.c    |  7 -------
 tools/virsh.c                 | 10 +++++++++-
 3 files changed, 16 insertions(+), 15 deletions(-)

-- 
2.53.0

Reply via email to