On 5/15/26 13:31, Ján Tomko wrote: > On a Friday in 2026, Michal Privoznik via Devel wrote: >> From: Michal Privoznik <[email protected]> >> >> For the VIR_NET_SSH_AUTH_PASSWORD authentication mechanism the >> virNetSSHAuthenticatePassword() is called. Inside it, >> virAuthGetPasswordPath() is called to obtain password. Firstly >> reading from our auth.conf file is attempted and if that fails >> then corresponding callback from virConnectAuthCallbackPtr is >> called. But virAuthGetPasswordPath() checks whether the callback >> is NULL or not. There is no need for > > I don't see a check for auth->cb in virAuthGetPasswordPath. > > In comparison, virAuthGetUsernamePath checks for both auth and auth->cb > before calling the callback.
Good point. I'll post a follow up patch for that. Michal
