Hi,

here are my comments:
* Do you have a particular purpose for the JTAG_OE signal? I can't see the 
point of letting the cable put all the JTAG wires in high impedance mode, so 
in my opinion this feature should be removed. Or, at least, the cable should 
be driving the JTAG pins by default so that we don't have to modify usual 
FT2232H JTAG software for this cable to work.
* You might want to add ESD protection devices on USB and UART (the JTAG level 
translator is already quite ruggedized itself) and connect the shell of the 
USB connector via a 1M and 4.7nF 250V resistor and capacitor in parallel for 
improved noise immunity (as recommended by USB spec).

Otherwise, all seem OK to me, good job :)

Thanks,
Sébastien
_______________________________________________
http://lists.milkymist.org/listinfo.cgi/devel-milkymist.org
IRC: #milkym...@freenode
Webchat: www.milkymist.org/irc.html
Wiki: www.milkymist.org/wiki

Reply via email to