Re: [OMPI devel] sockaddr* vs. sockaddr_storage*

[George Bosilca]

It's against my "religion" to back off someone else commit. First I try to understand why and how to fix it. After the IPv6 commit, it took me 2 days to bring the trunk back to the stage where it was before (i.e. restore the lost functionality).

  Thanks,
    george.



On Apr 29, 2007, at 10:00 AM, Adrian Knoth wrote:

I have to ask you to remove r14549 quickly as it bring back the trunk to the stage it was before r14544 (only random support for multiple BTL). It's not that I don't care about IPv6, it's just that I care more about multi TCP BTL working in the way it is supposed to work. Moreover, I'm sure it's not the real fix you're looking for. PS: Please read the commit log for the r14544. It explain why I changed from sockaddr_storage* to sockaddr*.

Hi, especially bosilca (George?)


to provide the desired functionality.

There's another question concerning r14544: why did you change
sockaddr_storage* to sockaddr* for some btl/tcp functions? Is there
something special about sockaddr*? For me, sockaddr_storage is a

in ipv6compat.h, so we could always make use of ss_family.


Cheerio

--
Cluster and Metacomputing Working Group
Friedrich-Schiller-Universität Jena, Germany

private: http://adi.thur.de
_______________________________________________
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel

r14544 broke the IPv6 support (see Ticket #1008). I've committed a quick patch, but I guess we (George and me?) will have to look closer in order complete replacement for sockaddr... we also have the necessary defines

smime.p7s
Description: S/MIME cryptographic signature