On Jul 26, 2007, at 1:01 PM, Mohamad Chaarawi wrote:
On Thu, July 26, 2007 1:18 pm, Brian Barrett wrote:
On Jul 26, 2007, at 12:00 PM, Mohamad Chaarawi wrote:
2) I think it would be better to always have the flags and macros
available (like OMPI_GROUP_SPORADIC and OMPI_GROUP_IS_SPORADIC)
even
when sparse groups are disabled. They dont' take up any space, and
mean less #ifs in the general code base
That's what i actually was proposing.. keep the flags (there are no
macros, just the GROUP_GET_PROC_POINTER) and the sparse parameters
in the
group strucutre, and this will mean, only 1 maybe 2 #ifs..
Why would this mean having the sparse parameters in the group
structure?
not sure if i understood your question right, but in the group
struct we
added 5 integers and 3 pointer.. if we want to compile these out,
we would
then need all the #ifs around the code where we use these parameters..
I don't follow why you would need all the sparse stuff in
ompi_group_t when OMPI_GROUP_SPARSE is 0. The OMPI_GROUP_IS and
OMPI_GROU_SET macros only modify grp_flags, which is always present.
Like the ompi_group_peer_lookup, much can be hidden inside the
functions rather than exposed through the interface, if you're
concerned about the other functionality currently #if'ed in the code.
Brian
