On Thu, July 26, 2007 2:07 pm, Brian Barrett wrote: > On Jul 26, 2007, at 1:01 PM, Mohamad Chaarawi wrote: > >> >> On Thu, July 26, 2007 1:18 pm, Brian Barrett wrote: >>> On Jul 26, 2007, at 12:00 PM, Mohamad Chaarawi wrote: >>> >>>>> 2) I think it would be better to always have the flags and macros >>>>> available (like OMPI_GROUP_SPORADIC and OMPI_GROUP_IS_SPORADIC) >>>>> even >>>>> when sparse groups are disabled. They dont' take up any space, and >>>>> mean less #ifs in the general code base >>>>> >>>> That's what i actually was proposing.. keep the flags (there are no >>>> macros, just the GROUP_GET_PROC_POINTER) and the sparse parameters >>>> in the >>>> group strucutre, and this will mean, only 1 maybe 2 #ifs.. >>> >>> Why would this mean having the sparse parameters in the group >>> structure? >> >> not sure if i understood your question right, but in the group >> struct we >> added 5 integers and 3 pointer.. if we want to compile these out, >> we would >> then need all the #ifs around the code where we use these parameters.. > > I don't follow why you would need all the sparse stuff in > ompi_group_t when OMPI_GROUP_SPARSE is 0. The OMPI_GROUP_IS and > OMPI_GROU_SET macros only modify grp_flags, which is always present. > I don't need them, right now they are compiled out.. but since they are, all functions using these parameters (example: translate_ranks_strided, the long lookup function) have to be also compiled out, and other common functions that changed (like translate ranks, where we now check if sparse groups are enabled so we use an easier translate_ranks corresponding to the storage type) have to have the #ifs to compile stuff out.
> Like the ompi_group_peer_lookup, much can be hidden inside the > functions rather than exposed through the interface, if you're > concerned about the other functionality currently #if'ed in the code. > in the ompi_group_peer_lookup that u suggested, we have an #if, so the same way with all functions that use sparse parameters.. I think i get what u are saying, Im don't want any functionality from including the sparse stuff when they are disabled, just easier code to look at.. > Brian > _______________________________________________ > devel mailing list > de...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/devel > -- Mohamad Chaarawi Instructional Assistant http://www.cs.uh.edu/~mschaara Department of Computer Science University of Houston 4800 Calhoun, PGH Room 526 Houston, TX 77204, USA
