:-) Nice catch. Please commit the fix. Pasha.
Jeff Squyres wrote:
Hah! Sweet; good catch -- feel free to delete that extra call. On Dec 5, 2007, at 6:42 PM, Jon Mason wrote:There is a double call to ompi_btl_openib_connect_base_open in mca_btl_openib_mca_setup_qps(). It looks like someone just forgot to clean-up the previous call when they added the check for the return code. I ran a quick IMB test over IB to verify everything is still working. Thanks, Jon Index: ompi/mca/btl/openib/btl_openib_mca.c =================================================================== --- ompi/mca/btl/openib/btl_openib_mca.c (revision 16855) +++ ompi/mca/btl/openib/btl_openib_mca.c (working copy) @@ -672,10 +672,7 @@ mca_btl_openib_component.credits_qp = smallest_pp_qp; /* Register any MCA params for the connect pseudo-components */ - - ompi_btl_openib_connect_base_open(); - - if ( OMPI_SUCCESS != ompi_btl_openib_connect_base_open()) + if (OMPI_SUCCESS != ompi_btl_openib_connect_base_open()) goto error; ret = OMPI_SUCCESS; _______________________________________________ devel mailing list de...@open-mpi.org http://www.open-mpi.org/mailman/listinfo.cgi/devel
