Hi Lenny,
This looks good. But I have a couple of suggestions (which others may
disagree with):
1. You register an opal mca parameter, but look it up in ompi, then call
a opal function with the result. What if you had a function
opal_paffinity_base_set_slots(long rank) (or some other name, I don't
care) which looked up the mca parameter and then setup the slots as you
are doing if it is fount. This would make things a bit cleaner IMHO.
2. the functions in the paffinety base should be prefixed with
'opal_paffinity_base_'
3. Why was the ompi_debug_flag added? It is not used anywhere.
4. You probably do not need to add the opal debug flag. There is already
a 'paffinity_base_verbose' flag which should suit your purposes fine. So
you should just be able to replace all of the conditional output
statements in paffinity with something like
opal_output_verbose(10, opal_paffinity_base_output, ...),
where 10 is the verbosity level number.
Tim
Lenny Verkhovsky wrote:
Hi, all
Attached patch for modified Rank_File RMAPS component.
1. introduced new general purpose debug flags
mpi_debug
opal_debug
2. introduced new mca parameter opal_paffinity_slot_list
3. ompi_mpi_init cleaned from opal paffinity functions
4. opal paffinity functions moved to new file
opal/mca/paffinity/base/paffinity_base_service.c
5. rank_file component files were renamed according to prefix policy
6. global variables renamed as well.
7. few bug fixes that were brought during previous discussions.
8. If user defines opal_paffinity_alone and rmaps_rank_file_path or
opal_paffinity_slot_list,
then he gets a Warning that only opal_paffinity_alone will be used.
.
Best Regards,
Lenny.
------------------------------------------------------------------------
_______________________________________________
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel
