Looks good to me. I would add some checks regarding the number and size of the segments and the allocated space (MCA_BTL_SEG_MAX_SIZE) to make sure we never hit the corner case where there are too many segments compared with the available space. And add a huge comment in the btl.h about the fact that mca_btl_base_segment_t should be used with extreme care.
george. On Jun 14, 2012, at 18:42 , Jeff Squyres wrote: > This sounds like a good thing to me. +1 > > On Jun 13, 2012, at 12:58 PM, Nathan Hjelm wrote: > >> What: hide btl segment keys from PML/OSC code. >> >> Why: As it stands new BTLs with larger segment keys (smcuda for example) >> require changes in both OSC/rdma as well as the PMLs. This RFC makes will >> make changes in segment keys transparent to all btl users. >> >> When: The changes are very straight-forward so I am setting the timeout for >> this to June 22, 2012 >> >> Where: See the attached patch or check out the bitbucket >> http://bitbucket.org/hjelmn/ompi-btl-interface-update >> >> All the relevant PMLs/BTLs + OSC/rdma have been updated with the exception >> of btl/wv. I have also tested the following components: >> - ob1 >> - csum >> - bfo >> - ugni (now works with MPI one-sides) >> - sm >> - vader >> - openib (in progress) >> >> Brian and Rolf, please take a look at your components and let me know if I >> screwed anything up. >> >> -Nathan Hjelm >> HPC-3, LANL >> _______________________________________________ >> devel mailing list >> de...@open-mpi.org >> http://www.open-mpi.org/mailman/listinfo.cgi/devel > > > -- > Jeff Squyres > jsquy...@cisco.com > For corporate legal information go to: > http://www.cisco.com/web/about/doing_business/legal/cri/ > > > _______________________________________________ > devel mailing list > de...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/devel
