On Feb 19, 2014, at 6:36 AM, George Bosilca <bosi...@icl.utk.edu> wrote:
> There is one minor thing I would suggest to change. In your patch > in_unexpected_list is defined as a bool, which translates to an int on most > platforms. This statement isn't true. sizeof(bool)==1 on my Mac and on our x86_64 Linux cluster at Cisco. I only mention it because this seems to be a common myth for some reason. > You can change it to an uint8_t and move the in_unexpected_list field in the > mca_pml_ob1_comm_proc_t to allow the compiler to pack it with the > expected_sequence. However, this is still a reasonable suggestion to ensure that we retain good control of our structure sizes/layouts. -Dave
