On Wed, Feb 19, 2014 at 8:37 AM, Dave Goodell (dgoodell) <dgood...@cisco.com > wrote:
> On Feb 19, 2014, at 6:36 AM, George Bosilca <bosi...@icl.utk.edu> wrote: > > > There is one minor thing I would suggest to change. In your patch > in_unexpected_list is defined as a bool, which translates to an int on most > platforms. > > This statement isn't true. sizeof(bool)==1 on my Mac and on our x86_64 > Linux cluster at Cisco. I only mention it because this seems to be a > common myth for some reason. > On x86 or x86-64 with Linux, Mac OSX, Solaris or {Net,Open,Free}BSD sizeof(_Bool) is 1. Same on PPC32 and PPC64 with Linux and Mac OSX. [I grepped a heap of recent configure output to be sure]. I do agree, however, that if you are explicitly packing a structure you should use uint8_t. -Paul -- Paul H. Hargrove phhargr...@lbl.gov Future Technologies Group Computer and Data Sciences Department Tel: +1-510-495-2352 Lawrence Berkeley National Laboratory Fax: +1-510-486-6900