Hi Howard and all,
i did push this intentionally, and i will run some more tests from now.
fwiw, these commits ran through the CI via PR
https://github.com/open-mpi/ompi/pull/2488
most of the time, and because of "my" time zone, the code base is not
modified
between the time i submit my PR and the CI tests results are available.
in order to avoid a useless merge commit message (that over-complexify
the git log output with
close to zero added value to me), i simply
git checkout master
git merge --ff-only topic/misc_fixes
git push origin master
though this does not generate a git commit, github.com is smart enough
to figure this out and marks the PR as merged.
Cheers,
Gilles
On 12/2/2016 8:28 AM, Howard Pritchard wrote:
Hi Gilles
I didn't see a merge commit for all these commits,
hence my concern that it was a mistake.
In general it's better to pull in commits via PR process.
Howard
Am Donnerstag, 1. Dezember 2016 schrieb Gilles Gouaillardet :
fwiw, the major change is in
https://github.com/open-mpi/ompi/commit/c9aeccb84e4626c350af4daa974d37775db5b25e
<https://github.com/open-mpi/ompi/commit/c9aeccb84e4626c350af4daa974d37775db5b25e>
and i did spend quite some time testing it.
if you are facing some unexpected issues with the latest master,
you might try to revert this locally and see if it helps
Cheers,
Gilles
On Friday, December 2, 2016, Gilles Gouaillardet
<gilles.gouaillar...@gmail.com
<javascript:_e(%7B%7D,'cvml','gilles.gouaillar...@gmail.com');>>
wrote:
Howard,
i pushed a bunch of commits yesterday, and that was not an
accident.
you might be referring
https://github.com/open-mpi/ompi/commit/cb55c88a8b7817d5891ff06a447ea190b0e77479
<https://github.com/open-mpi/ompi/commit/cb55c88a8b7817d5891ff06a447ea190b0e77479>
but it has already been reverted 9 days ago with
https://github.com/open-mpi/ompi/commit/1e2019ce2a903be24361b3424d8e98d27e941c6c
<https://github.com/open-mpi/ompi/commit/1e2019ce2a903be24361b3424d8e98d27e941c6c>
Cheers,
Gilles
On Friday, December 2, 2016, r...@open-mpi.org
<r...@open-mpi.org> wrote:
I should add, FWIW: I’m working with the HEAD of master
right now, and not seeing any problems.
On Dec 1, 2016, at 2:10 PM, r...@open-mpi.org wrote:
?? I see a bunch of commits that were all collected in a
single PR from Gilles yesterday - is that what you are
referring to?
On Dec 1, 2016, at 1:58 PM, Howard Pritchard
<hpprit...@gmail.com> wrote:
Hi Folks,
Just an FYI it looks like a bunch of commits may have
been accidentally pushed to
master sometime in the past day. You may not want to
merge origin/master (if origin is
how you reference https://github.com/open-mpi/omp
<https://github.com/open-mpi/omp>) into your master or
rebase off
of it until we get some clarity on what has happened.
Howard
_______________________________________________
devel mailing list
devel@lists.open-mpi.org
https://rfd.newmexicoconsortium.org/mailman/listinfo/devel
<https://rfd.newmexicoconsortium.org/mailman/listinfo/devel>
_______________________________________________
devel mailing list
devel@lists.open-mpi.org
https://rfd.newmexicoconsortium.org/mailman/listinfo/devel
_______________________________________________
devel mailing list
devel@lists.open-mpi.org
https://rfd.newmexicoconsortium.org/mailman/listinfo/devel
