that might be interesting too : https://cla-assistant.io/
Cheers, Gilles On Thu, Jul 13, 2017 at 8:20 PM, Jeff Squyres (jsquyres) <jsquy...@cisco.com> wrote: > That's a good point. > > Hmmm. How would it recognize a revert commit? > > Sidenote... I think we'll likely have more details soon (in an email? wiki? > something...), but we had a great discussion about adding some more bots to > our GitHub usage. > > We found this: > > https://github.com/probot > (e.g., https://github.com/probot/probot) > > Which might be a great platform on which to base our bots (vs. the existing > signed-off-by-checker and email checker that are custom written by me). > > Something to look into... > > >> On Jul 13, 2017, at 12:21 AM, Gilles Gouaillardet <gil...@rist.or.jp> wrote: >> >> Thanks Jeff, >> >> >> one more improvement : could you please have the bot also ignore revert >> commits ? >> >> >> Cheers, >> >> >> Gilles >> >> >> On 7/7/2017 11:56 PM, Jeff Squyres (jsquyres) wrote: >>> FYI: the "signed-off-by-checker" CI on Github now ignores merge commits >>> (because those usually aren't signed -- e.g., if you file PR A against an >>> existing PR B, when someone merges A into B, there's now a merge commit on >>> B). Previously, the signed-off-by-checker would flag such merge commits as >>> not being signed. >>> >>> You can see the new behavior on https://github.com/open-mpi/ompi/pull/3822. >>> >>> Specifically: #3822 contains a merge commit from >>> https://github.com/tjcw/ompi/pull/1. >>> >>> The signed-off-by-checker now ignores that merge commit on #3822 and >>> indicates that all the commits on 3822 are ok. >>> >>> Woo hoo! >>> >> >> _______________________________________________ >> devel mailing list >> devel@lists.open-mpi.org >> https://rfd.newmexicoconsortium.org/mailman/listinfo/devel > > > -- > Jeff Squyres > jsquy...@cisco.com > > _______________________________________________ > devel mailing list > devel@lists.open-mpi.org > https://rfd.newmexicoconsortium.org/mailman/listinfo/devel _______________________________________________ devel mailing list devel@lists.open-mpi.org https://rfd.newmexicoconsortium.org/mailman/listinfo/devel
