Good catches -- I updated the hwloc (to "hwloc2") bit, but I'll leave the "bar50" edits to Brian/Ralph, since they wrote that section.
Meaning: I *think* you're right, but I'm going to let them do it... :-0 On Jan 7, 2020, at 4:47 PM, Brice Goglin via devel <devel@lists.open-mpi.org<mailto:devel@lists.open-mpi.org>> wrote: Thanks a lot for writing all this. At the end https://github.com/open-mpi/ompi/wiki/GitSubmodules#adding-a-new-submodule-pointing-to-a-specific-commit should "bar" be "bar50x" in line "$ git add bar" ? It seems to me that you are in opal/mca/foo and the new submodule is in "bar50x" (according to "cd opal/mca/foo/bar50x" at the beginning). There's also a "bar-50x" instead of "bar50x" in line "git submodule add --name bar-50x ...". Should the submodule name match the directory name? By the way, in https://github.com/open-mpi/ompi/wiki/GitSubmodules#updating-the-commit-that-a-submodule-refers-to you may want to rename hwloc201 into hwloc2 to avoid confusion and match the current PR. Brice (who cannot edit the wiki :)) Le 07/01/2020 à 18:02, Jeff Squyres (jsquyres) via devel a écrit : We now have two PRs pending that will introduce the use of Git submodules (and there are probably more such PRs on the way). At last one of these first two PRs will likely be merged "Real Soon Now". We've been talking about using Git submodules forever. Now we're just about ready. ************************************** *** DEVELOPERS: THIS AFFECTS YOU!! *** ************************************** You cannot just "clone and build" any more: ----- git clone g...@github.com:open-mpi/ompi.git<mailto:g...@github.com:open-mpi/ompi.git> cd ompi && ./autogen.pl && ./configure ... ----- You will *have* to initialize the Git submodule(s) -- either during or after the clone. *THEN* you can build Open MPI. Go read this wiki: https://github.com/open-mpi/ompi/wiki/GitSubmodules May the force be with us! -- Jeff Squyres jsquy...@cisco.com<mailto:jsquy...@cisco.com>
