Hi, Thomas

Maybe 'mesh_fwding' for brevity?


Ok.


> Ideally, this wouldn't really be necessary.


If according to my patch, I observed that if you do the following:
Mesh Node 1 creates mesh interface and no other mesh nodes in the
neighborhood and then executing "iw mesh0 set mesh_param mesh_forwarding
0". Then another mesh node 2 is joining the mesh network. Mesh node 1 and 2
can establish the link. But mesh node 1 need to initiate the first packet
(let say ping or DHCP request) before both can communicate. If mesh node 2
try to ping mesh node 1 without mesh node 1 sent a packet first, mesh node
2 cannot ping mesh node 1.


> A commit message describing what this patch does would be nice :)


Ok. Will do


>
> This check is redundant. It sounds like dot11MeshForwarding only
> prevents forwarding of PREQ frames (which you caught above), thereby
> preventing the creation of multihop mpaths with this node as the
> destination.
>
>
To be safe, this is a possibility that a user alters his mpath table to
reach a destination via a specific node, such as "iw mesh0 mpath set <MAC1>
next_hop <MAC2>". So if MAC2 is set to not forwarding and this checking is
there, it will ensure that the data is not forwarded even force by a
particular mesh node. I have tested this scenario thus putting this
checking here. Please comment.


> Commit message.
>
> Ok


>
> Doesn't belong here, but thanks :)
>
>
Ok. Using master copy from github, need to add this to ensure iw working.


>
> Extra newline.
>
> Noted

Regards,
Chun-Yeow
_______________________________________________
Devel mailing list
[email protected]
http://open80211s.com/mailman/listinfo/devel

Reply via email to