On Thu, 2012-06-07 at 12:39 +0800, Chun-Yeow Yeoh wrote:
Ok actually, I won't take it as-is:
> + if (_chg_mesh_attr(NL80211_MESHCONF_HWMP_ACTIVE_PATH_TO_ROOT_TIMEOUT,
> + mask))
that indentation is wrong
> + conf->dot11MeshHWMPactivePathToRootTimeout =
> + nconf->dot11MeshHWMPactivePathToRootTimeout;
> + if (_chg_mesh_attr(NL80211_MESHCONF_HWMP_ROOT_INTERVAL, mask)) {
> + conf->dot11MeshHWMProotInterval =
> + nconf->dot11MeshHWMProotInterval;
> + }
that shouldn't have braces
> +IEEE80211_IF_FILE(dot11MeshHWMPactivePathToRootTimeout,
> + u.mesh.mshcfg.dot11MeshHWMPactivePathToRootTimeout, DEC);
> +IEEE80211_IF_FILE(dot11MeshHWMProotInterval,
> + u.mesh.mshcfg.dot11MeshHWMProotInterval, DEC);
that indentation is also wrong
> FILL_IN_MESH_PARAM_IF_SET(tb, cfg, ht_opmode,
> mask, NL80211_MESHCONF_HT_OPMODE, nla_get_u16);
> + FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshHWMPactivePathToRootTimeout,
> + mask, NL80211_MESHCONF_HWMP_ACTIVE_PATH_TO_ROOT_TIMEOUT,
> + nla_get_u32);
> + FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
> + dot11MeshHWMProotInterval, mask,
> + NL80211_MESHCONF_HWMP_ROOT_INTERVAL,
> + nla_get_u16);
and that, even though it matches the current surrounding style.
johannes
_______________________________________________
Devel mailing list
[email protected]
http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel
