On Tue, Apr 9, 2013 at 2:42 AM, Johannes Berg <[email protected]> wrote:
> On Tue, 2013-04-09 at 11:38 +0200, Johannes Berg wrote:
>> On Mon, 2013-04-08 at 11:06 -0700, Thomas Pedersen wrote:
>> > Some drivers (like ath9k_htc) will take a mutex in
>> > rate_control_rate_update(), so drop the sta lock before we
>> > get there.
>>
>> That driver is broken then. rate_control_rate_update() can be called
>> from the RX path where this also isn't allowed.
>
>  * @sta_rc_update: Notifies the driver of changes to the bitrates that
> can be
>  *      used to transmit to the station. The changes are advertised with
> bits
>  *      from &enum ieee80211_rate_control_changed and the values are
> reflected
>  *      in the station data. This callback should only be used when the
> driver
>  *      uses hardware rate control (%IEEE80211_HW_HAS_RATE_CONTROL)
> since
>  *      otherwise the rate control algorithm is notified directly.
>  *      Must be atomic.
>
> (note last line)

Ah alright. Thanks.

-- 
Thomas
_______________________________________________
Devel mailing list
[email protected]
http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel

Reply via email to