On Wed, 2013-04-10 at 10:36 -0700, Thomas Pedersen wrote: > > However it seems that ieee80211_queue_stopped() is actually kinda broken > > and should only return the 'driver-stopped' reason to start with. If you > > fix that, it's probably good enough for you. I don't think in patch 4 > > you should drop frames for scanning, for example. > > It looks like mac80211 already just checks local->queue_stop_reasons > for being 0 (or not), so that check would still hold. I'm not 100% > sure the driver calls to ieee80211_queue_stopped() only returning true > for REASON_DRIVER are ok? What if the queues are being flushed, or say > REASON_PS is set?
I looked at the drivers, and while (almost?) all of them use it incorrectly they really want only REASON_DRIVER. In fact, they'd be better off with just that even in the incorrect usages. johannes _______________________________________________ Devel mailing list [email protected] http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel
