On Wed, May 29, 2013 at 12:52 PM, Johannes Berg
<[email protected]>wrote:
> On Wed, 2013-05-29 at 12:21 -0700, Jacob Minshall wrote:
> > Max peerings capped at 63 in accordance with IEEE-2012 8.4.2.100.7,
> > and trigger a beacon regeneration every time the number of peerings
> > changes.
>
> Can you write full sentences? Maybe also in the subject ("set mesh ...
> properly"?) :-)
>
set mesh formation field properly
Cap max peerings at 63 in accordance with IEEE-2012 8.4.2.100.7.
Triggers a beacon regeneration every time the number of peerings changes.
Previously this would only happen if the "accepting peerings" big changed.
How's this?
>
>
> > - neighbors = (neighbors > 15) ? 15 : neighbors;
> > + neighbors = (neighbors > IEEE80211_MAX_MESH_PEERINGS) ?
> > + IEEE80211_MAX_MESH_PEERINGS : neighbors;
>
> min() or min_t()?
>
changing to min_t for v2
>
> > atomic_inc(&sdata->u.mesh.estab_plinks);
> > - return mesh_accept_plinks_update(sdata);
> > + mesh_accept_plinks_update(sdata);
> > + return BSS_CHANGED_BEACON;
>
> These changes seem odd to me, why doesn't mesh_accept_plinks_update()
> just return the change value then?
>
> johannes
>
>
_______________________________________________
Devel mailing list
[email protected]
http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel
