Hi, Bob net_traversal_jiffies as claimed in [1] is used to improve patch stability in short term. This patch is more or less like eliminating the purpose of net_traversal_jiffies, right?
Also, as mentioned in [1], should we also consider the subsequent PREQs with same metric instead of just only better metric in our current implementation? Regards, Chun-Yeow [1] Rosario G. Garroppo, et al. , "A joint experimental and simulation study of the IEEE 802.11s HWMP protocol and airtime link metric" On Sun, Feb 9, 2014 at 7:34 PM, Bob Copeland <[email protected]> wrote: > When a path target responds to a path request, its response > always contains the most up-to-date information; accordingly, > it should use the latest target_sn, regardless of > net_traversal_jiffies(). Otherwise, only the first path > response is considered when constructing a path, as it will > have the highest target_sn of all replies during that period. > > Signed-off-by: Bob Copeland <[email protected]> > --- > net/mac80211/mesh_hwmp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c > index 03ff5ea..94758b9 100644 > --- a/net/mac80211/mesh_hwmp.c > +++ b/net/mac80211/mesh_hwmp.c > @@ -544,9 +544,10 @@ static void hwmp_preq_frame_process(struct > ieee80211_sub_if_data *sdata, > if (time_after(jiffies, ifmsh->last_sn_update + > net_traversal_jiffies(sdata)) || > time_before(jiffies, ifmsh->last_sn_update)) { > - target_sn = ++ifmsh->sn; > + ++ifmsh->sn; > ifmsh->last_sn_update = jiffies; > } > + target_sn = ifmsh->sn; > } else if (is_broadcast_ether_addr(target_addr) && > (target_flags & IEEE80211_PREQ_TO_FLAG)) { > rcu_read_lock(); > -- > 1.8.5.2 > > _______________________________________________ > Devel mailing list > [email protected] > http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel _______________________________________________ Devel mailing list [email protected] http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel
