On Fri, Apr 04, 2014 at 04:41:45PM -0700, Colleen Twitty wrote: > [PATCH v2] mac80211: mesh: update target SN when new origin SN RX'ed > > This patch is to address a HWMP mesh path selection bug > found by Bob Copeland. If a STA sends a PREQ, it may > reach its target as multiple PREQs via PREQ propagation. > Previously, if the STA is the target, it would increment > its own SN if it was within net_traversal_jiffies of the > last update *and* use this as the target SN in the PREP. > The PREQs arriving just after (less than > net_traversal_jiffies later) would not meet the criteria > for SN update and would use the older SN. Later, these > paths would be ignored during path selection since an > older SN indicates a staler path.
Maybe I should just submit patch 3/3 as-is and then do this work on top? It would save some explanation and make this more of a "one-thing-per-patch".. > > Signed-off-by: Colleen Twitty <[email protected]> > --- > changes: > renaming old_sn to old_orig_sn, use SN_GT instead of LT (Bob Copeland) Except you changed chk_old_sn and not old_sn :) I had suggested SN_GE (which was the same as the original code) but I guess we do actually want SN_GT here. -- Bob Copeland %% www.bobcopeland.com _______________________________________________ Devel mailing list [email protected] http://lists.open80211s.org/cgi-bin/mailman/listinfo/devel
