Hello.
On Sat, 2011-09-24 at 13:30, Tormod Volden wrote:
> On Sat, Sep 24, 2011 at 12:50 PM, Stefan Schmidt wrote:
>
> > Would be great to add logs for your devices once you find time for
> > doing it. Actually anybody who uses dfu-util successfully with some
> > devices that are not listed should take the moment and prepare a log
> > for us. Just send them here.
>
> It will also be very helpful to have the dfu-util -v -v ... output
> from each device, so I can see which paths are being taken, and over
> time reduce some cargo-cult. This should ideally be updated after each
> release we make.
Hmm, for which modes you want this? Listing, donwload, upload, all?
This can give us a lot permutations. We can experiment with it
thought. Will do some logs when I'm doing the logs for the devices in
dfu mode. If my diploma-thesis progress allows me it will happen this
we. :)
> > I switched a bit back and forth between the patch and the whole code.
> > It all looked good to me and the testing for all devices worked
> > without problem. Just a small nitpick below.
> >
> >> +
> >> + ret = libusb_get_active_config_descriptor(dfu_if->dev, &cfg);
> >> + if (ret == LIBUSB_ERROR_NOT_FOUND) {
> >> + fprintf(stderr, "Error: Device is unconfigured\n");
> >> + return -1;
> >> + } else if (ret) {
> >> + fprintf(stderr, "Error: failed "
> >> + "libusb_get_config_descriptor_by_value()\n");
> >
> > Here should go the correct function we fail on. :) I fixed that up for
> > you after I merged the patch.
>
> I also have some nitpicks with my patch. I did not get to send an
> updated patch in time, but will send a follow-up patch. Which happens
> to revert your fix-up :)
Well, such is life. :)
regards
Stefan Schmidt
_______________________________________________
devel mailing list
devel@lists.openmoko.org
https://lists.openmoko.org/mailman/listinfo/devel
