Mike Christie wrote: > Christopher Leech wrote: >> Vasu Dev wrote: >>> This will ensure exch will get freed if exch ref dropped to zero >>> in fc_exch_mgr_delete_ep(). >> That's ... interesting. The count will never be different at the end of >> fc_exch_mgr_delete_ep() than it is at the beginning. The hold and >> release you add here are working around the fact that >> fc_exch_done_locked() decrements the count without checking to see if it >> became zero. >> >> I was looking at the same problem yesterday, and I think a better >> solution is to never decrement the count without testing, and to protect > > I do not disagree about that. The original code did a decrement only
I mean it will look nicer but it should not change anything about the caller having a hold that it will release when it is done. _______________________________________________ devel mailing list [email protected] http://www.open-fcoe.org/mailman/listinfo/devel
