On Mon, 2010-08-30 at 21:26 +0000, Bhanu Gollapudi wrote: > In fcoe_ctlr_els_send, we determine to be in FIP or non-FIP mode based > on fip->flogi_count, and at the 3rd unsuccessful FLOGI attempt, we fall > back to non-FIP mode. This takes around 8 secs time. So we expect a FIP > discovery advertisement from the switch within 8 secs to not fall back > to non-FIP mode. > > I think this is too less a time to give up FIP mode, as when RSTP > protocol is enabled in the switch I've seen the cases where the switch > can take a little longer than 8 secs to send a discovery advertisement, > even though the FKA_ADV_PERIOD is default 8 secs. We can also have > problems when the switch administrator changes the default value to > 8 > secs. > > I think we should have reasonably high FIP FLOGI retries (10 ??) before > falling back to non-FIP mode. > > Please let me know your thoughts. >
I think that increasing the retry count would help a lot, but there could still be a race depending on the switch's behavior. An alternative would be to get rid of non-FIP mode completely. Now that there is VN2VN for point-to-point mode, I don't see the necessary of non-FIP mode. I'm a bit reluctant to yank it out completely though, I seem to think that fnic is using non-FIP mode in some case(s). [ Joe correct me if I'm wrong on this ] One option that we've tossed around here is to set the default mode to FIP-only in fcoe.ko. That way another LLD could override it, but it would be FIP-only for netdev based drivers. //Rob _______________________________________________ devel mailing list [email protected] http://www.open-fcoe.org/mailman/listinfo/devel
