On Mon, 2010-08-30 at 16:01 -0700, Bhanu Gollapudi wrote: > > I'm sorry, I may be missing something here. Are we referring to > FIP_MODE_AUTO as FIP-only mode? In that case, if fip->mode is > FIP_MODE_AUTO, we can infinitely retry for FIP FLOGI instead of > falling > back to non-FIP mode (ignoring flogi_count) in fcoe_ctlr_else_send(). > That way LLDs can get rid of non-FIP mode completely based on the mode > with which they init the ctlr. Is this acceptable?
FIP_MODE_AUTO starts with FIP and then falls back to non-fip after above mentioned retries done, you need to change this to FIP_MODE_FABRIC to prevent fall back to non-fip for only fcoe.ko and that way fcoe.ko would always remain only in FIP mode by default, so minor change below should do that:- diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c index 280a4df..1baedec 100644 --- a/drivers/scsi/fcoe/fcoe.c +++ b/drivers/scsi/fcoe/fcoe.c @@ -117,7 +117,7 @@ static void fcoe_recv_frame(struct sk_buff *skb); static void fcoe_get_lesb(struct fc_lport *, struct fc_els_lesb *); -module_param_call(create, fcoe_create, NULL, (void *)FIP_MODE_AUTO, S_IWUSR); +module_param_call(create, fcoe_create, NULL, (void *)FIP_MODE_FABRIC, S_IWUSR); __MODULE_PARM_TYPE(create, "string"); MODULE_PARM_DESC(create, " Creates fcoe instance on a ethernet interface"); module_param_call(create_vn2vn, fcoe_create, NULL, _______________________________________________ devel mailing list [email protected] http://www.open-fcoe.org/mailman/listinfo/devel
