On Wed, 2010-10-06 at 18:04 -0700, Robert Love wrote:
> We have duplicate routines using the __init and
> __exit keywords. Remove the unnecessary identifiers.
>
> Also add the 'static' identifier to the fcoe_if_exit
> routine as it's only called locally and make fcoe_if_exit
> return void as the return value is not used.
>
> Signed-off-by: Robert Love <[email protected]>
> ---
> drivers/scsi/fcoe/fcoe.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
> index d23a538..9615489 100644
> --- a/drivers/scsi/fcoe/fcoe.c
> +++ b/drivers/scsi/fcoe/fcoe.c
> @@ -1045,7 +1045,7 @@ out:
> *
> * Returns: 0 on success
> */
> -static int __init fcoe_if_init(void)
> +static int fcoe_if_init(void)
> {
> /* attach to scsi transport */
> fcoe_transport_template = fc_attach_transport(&fcoe_transport_function);
> @@ -1067,13 +1067,12 @@ static int __init fcoe_if_init(void)
> *
> * Returns: 0 on success
> */
v3 coming with fix for this comment.
> -int __exit fcoe_if_exit(void)
> +static void fcoe_if_exit(void)
> {
> fc_release_transport(fcoe_transport_template);
> fc_release_transport(fcoe_vport_transport_template);
> fcoe_transport_template = NULL;
> fcoe_vport_transport_template = NULL;
> - return 0;
> }
>
> /**
>
> _______________________________________________
> devel mailing list
> [email protected]
> http://www.open-fcoe.org/mailman/listinfo/devel
_______________________________________________
devel mailing list
[email protected]
http://www.open-fcoe.org/mailman/listinfo/devel
