On Wed, 2010-10-06 at 20:41 -0700, Chris Leech wrote: > What is this trying to solve? > I just thought they were unnecessary. I guess they shouldn't be removed.
> __init and __exit just mark the function to be placed in special init > and exit text sections. If you statically compile directly into the > kernel, then __init code is freed after it has run once and __exit > code is left out completely because you can't remove the module. They > don't cause them to be run as initcalls or anything, and if a function > is only ever called from the modules init or exit routines they should > be marked with __init or __exit. > I figured that they weren't called as initcalls because there weren't module_init() or module_exit() definitions. So, I thought they were just unnecessary. I guess they're good. I'll change this patch to only make fcoe_if_exit() static and void. Thanks, //Rob _______________________________________________ devel mailing list [email protected] http://www.open-fcoe.org/mailman/listinfo/devel
