On 10/14/2010 10:43 AM, John Fastabend wrote: > Use the rport value for rec_tov for timeout values when > sending fcp commands. Currently, defaults are being used > which may or may not match the advertised values. > > The default may cause i/o to timeout on networks that > set this value larger then the default value. To make > the timeout more configurable in the non-REC mode we > remove the FC_SCSI_ER_TIMEOUT completely allowing the > scsi-ml to do the timeout. This removes an unneeded > timer and allows the i/o timeout to be configured > using the scsi-ml knobs. >
Does fcoe commands timeout more frequently than other transports? I like the idea of removing FC_SCSI_ER_TIMEOUT, because the timer duplicates the scsi cmd timeout. The only drawback to removing it is if it is common for commands to time out then relying on the scsi eh has 2 problems. 1. When the cmd timesout, the scsi layer stops the entire host while it aborts commands. 2. It aborts commands one at a time. So handling this problem is going to be a lot slower. However, I would say we should fix the scsi eh to help all drivers. 10 secs for a command to complete is too low. _______________________________________________ devel mailing list [email protected] http://www.open-fcoe.org/mailman/listinfo/devel
