On Tue, 2007-09-18 at 10:20 +0400, Pavel Emelyanov wrote: > Trond Myklebust wrote: > > On Mon, 2007-09-17 at 11:57 +0400, Pavel Emelyanov wrote: > >> The __mandatory_lock(inode) macro makes the same check, but > >> makes the code more readable. > > > > Could we please avoid using underscores in macros. Also, why are we > > breaking the usual convention of capitalising macro names? > > Sorry, I've forgot to change all the log - this is not a macro, > but a static inline function. The underscores are here, because > the mandatory_lock() one already exists and additionally checks > for "if (IS_MANDLOCK(inode))"
OK. I withdraw my objection then. Cheers Trond _______________________________________________ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo/devel
