On 05/13/2013 12:11 PM, Igor M Podlesny wrote: > On 13 May 2013 16:11, Glauber Costa <glom...@parallels.com> wrote: >> On 05/13/2013 12:08 PM, Igor M Podlesny wrote: >>> On 13 May 2013 15:50, Glauber Costa <glom...@parallels.com> wrote: >>> [...] >>>>> Aren't macroses supposed to be UPPER CASE named? >>>>> >>>> Yes, and for a reason: macros behave very differently than functions, >>>> and a convention to allow us to spot them and identify them as macros >>>> very easily is beneficial. >>>> >>>> This particular macro is defined right before the function, and >>>> undefined right after it, so it should be extremely clear to every >>>> reader that this is a macro. In this case, I don't see a reason for >>>> being so strict. >>> >>> As to me it's a nice opportunity to fix this along. >>> >> Fix what? > > Fix lower_cases exception for MACRO
putting CC back The way I see it, there is absolutely nothing to fix here. As I explained above, I believe coding style exists for a reason, and call for consistency to help one derive things about unknown code easier. This is a local macro, only exist within the scope of this function, it is use-once-and-forget, and won't be available anywhere else in the code. In this particular case, the only difference between the existing and proposed version is that one is easier to type, and the other is harder. _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel
