Hello Tal.

This is still a miracle for me. If you are curious you can check the patch
that fixed it [1]. As you see the comment handling was just causing a dead
"return" and as I see this is the file that was not really changed.
However, I was not initially maintaining the hooks functionality so I might
be just not able to trace the deployments being done there on the server.
So it might be that other solution was in place there at the time it was
working.

Along the lines I also noted that we were silently loosing the exceptions
happened in the hooks code as stderr was essentially lost. Now they are
redirected to the log file instead. So hope we should be able to quicker
react on hook issues from now on.

[1] https://gerrit.ovirt.org/#/c/91292/2/hooks/hook-dispatcher

On Thu, May 17, 2018 at 1:28 PM, Tal Nisan <tni...@redhat.com> wrote:

> Great news Anton, this will really make stable branch maintainers' life
> easier!
>
> Just out of curiosity since it's just stopped working at some point a few
> months ago, what was the problem there?
>
>
> On Thu, May 17, 2018 at 12:36 PM, Anton Marchukov <amarc...@redhat.com>
> wrote:
>
>> Hello All.
>>
>> We have fixed the Rerun-Hooks comment functionality on gerrit.ovirt.org
>> and you should be able to start using it now.
>>
>> The most common use case for this is to rerun all patchset-created hooks
>> on a patch. Just leave a comment with:
>>
>> Rerun-Hooks: all
>>
>> and shortly you will get the hooks to be re-executed and output delivered
>> as a gerrit comment (same as you would just submitted the patch).
>>
>> This also supports rerunning individual hooks. But it is a bit less
>> straightforward as you need to know the hook file name. E.g. the following
>> is possible:
>>
>> Rerun-Hooks: patchset-created.bz.1.check_bug_url,
>> patchset-created.bz.2.check_product
>>
>> you can see the default hooks list at [1].
>>
>> I think most of the time "Rerun-Hooks: all" will do the job and it is
>> all you need to remember.
>>
>> Note that currently it is possible to rerun online patchset-created hooks.
>>
>> Anton.
>>
>> [1] https://gerrit.ovirt.org/gitweb?p=gerrit-admin.git;a=tree;f=
>> hooks/default-hooks/all
>>
>> --
>> Anton Marchukov
>> Team Lead - Release Management - RHV DevOps - Red Hat
>>
>>
>> _______________________________________________
>> Devel mailing list -- devel@ovirt.org
>> To unsubscribe send an email to devel-le...@ovirt.org
>>
>>
>


-- 
Anton Marchukov
Team Lead - Release Management - RHV DevOps - Red Hat
_______________________________________________
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org

Reply via email to