Hi Cenk! > I like your proposed guideline.
Thanks! > What's your opinion on adding some words about logically splitting a PR > across several commits. I always like it when a PR contains 1 commit for the > new feature / bugfix and 1 commit for new/modified (unit)tests. This way I > can review them separately in github. Good idea. Although it should be already covered by point 7 of the Development Procedures [1]. Cheers, Oleg [1] https://github.com/RIOT-OS/RIOT/wiki/Development-procedures -- /* So there I am, in the middle of my `netfilter-is-wonderful' talk in Sydney, and someone asks `What happens if you try to enlarge a 64k packet here?'. I think I said something eloquent like `fuck'. */ linux-2.4.3/net/ipv4/netfilter/ip_nat_ftp.c
signature.asc
Description: PGP signature
_______________________________________________ devel mailing list [email protected] https://lists.riot-os.org/mailman/listinfo/devel
