Hi, Any feedback on this? I'm probably not submitting patches in the correct style - please guide me on what you need?

Thanks

Ed W


On 11/06/2020 17:57, Ed W wrote:
On 11/06/2020 17:20, Ed W wrote:
Hi!

Haha! So obvious now that you've pointed it out!! Yes, I confirm that this is the problem! I never even thought to look for such macros upstream! Thanks!

OK, can I propose a patch to uclibc-ng to change the naming of the unused fields to include "uclibc" in the name. This is in the style of glibc, which does the same (only with __glibc_unused)

Signed off: Ed Wildgoose <[email protected]>


Apologies. Previous patch was obviously useless... I'm tired and not thinking before writing. More useful patch submitted, it amends all architectures and renames the spare fields to include a namespace (__uclibc_).

Patch created with:

  sed -i -e 's/__unused/__uclibc_unused/' libc/sysdeps/linux/*/bits/*stat.h

This is inline with what glibc is doing, they tend to call spare fields either __glibc_unused or __glibc_reserved


Thanks so much for putting me on the right track to resolving this

Ed W



_______________________________________________
devel mailing list
[email protected]
https://mailman.uclibc-ng.org/cgi-bin/mailman/listinfo/devel



_______________________________________________
devel mailing list
[email protected]
https://mailman.uclibc-ng.org/cgi-bin/mailman/listinfo/devel

Reply via email to