Thanks
As you are generously accepting a styling-change type patch, I've gone
all-in and changed all such usages in all headers...
This obviously touches a lot of lines (in a very small way). I have
checked it several times for gremlins, it's currently compiling my build
image, etc. However, I only test on x86 architectures
For reference I only saw two mentions of something like __unused that
weren't in a struct, ie were in a function definition, so I think it's
not too risky that I missed something.
(Patch submitted separately)
Kind regards
Ed W
On 15/06/2020 15:14, Waldemar Brodkorb wrote:
Hi,
All is fine. I have just seen that the latest dhcpcd is compiling fine with out
the patch, but I will apply anyway.
Best regards
Waldemar
Am 15.06.2020 um 15:55 schrieb Ed W <[email protected]>:
Hi, Any feedback on this? I'm probably not submitting patches in the correct
style - please guide me on what you need?
Thanks
Ed W
On 11/06/2020 17:57, Ed W wrote:
On 11/06/2020 17:20, Ed W wrote:
Hi!
Haha! So obvious now that you've pointed it out!! Yes, I confirm that this is
the problem! I never even thought to look for such macros upstream! Thanks!
OK, can I propose a patch to uclibc-ng to change the naming of the unused fields to
include "uclibc" in the name. This is in the style of glibc, which does the
same (only with __glibc_unused)
Signed off: Ed Wildgoose <[email protected]>
Apologies. Previous patch was obviously useless... I'm tired and not thinking
before writing. More useful patch submitted, it amends all architectures and
renames the spare fields to include a namespace (__uclibc_).
Patch created with:
sed -i -e 's/__unused/__uclibc_unused/' libc/sysdeps/linux/*/bits/*stat.h
This is inline with what glibc is doing, they tend to call spare fields either
__glibc_unused or __glibc_reserved
Thanks so much for putting me on the right track to resolving this
Ed W
_______________________________________________
devel mailing list
[email protected]
https://mailman.uclibc-ng.org/cgi-bin/mailman/listinfo/devel
_______________________________________________
devel mailing list
[email protected]
https://mailman.uclibc-ng.org/cgi-bin/mailman/listinfo/devel
_______________________________________________
devel mailing list
[email protected]
https://mailman.uclibc-ng.org/cgi-bin/mailman/listinfo/devel
