On Mon, 3 Feb 2003, Keith Packard wrote:

>> Is there anywhere in the X source code that *gasp* uses ANSI 
>> trigraphs and relies on this broken^Wwonderful feature of ANSI C 
>> being enabled?  ;o)
>
>I sure hope not.  I've certainly never seen any such code (and would have 
>fixed it if I had).
>
>> I'm wondering wether disabling trigraphs by default in stock 
>> sources is considered OK, or if I should have my patch escape the 
>> trigraph sequences to not be tokenized instead?
>
>You should fix your patch to not use that trigraph.  Does GCC have a mode 
>that pukes if it finds any trigraphs?  That would be a better option than 
>disabling them; X gets built with other compilers still, some of which 
>might not have an option to disable trigraphs.

Yeppers, that's the most sensible solution, and the one I've 
decided to take as well.

Thanks for the feedback Keith


-- 
Mike A. Harris


_______________________________________________
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel

Reply via email to