Around 22 o'clock on Feb 21, David Dawes wrote: > The '#pragma weak' was only used as a short cut. To be more portable, > dummy functions that FatalError() would be provided in the case where > the incorrect one for the OS gets called.
Ok. I don't pretend to understand mystic GCC #pragmas well enough to even attempt such a short cut. > As for the other changes, I > opted to keep the "xf86setjmp" entry point rather than use it as the > macro name. Although it probably doesn't matter much, this would allow > older modules that use setjmp to work in thoses cases where the old > xf86jmp_buf size was large enough. Seems like a reasonable approach. I went the other direction and made sure that older modules would break on every system instead of happening to work on newer systems while failing on older ones. Just depends on which failure you prefer. > If we run into cases that can't reasonably be handled, then that's our > fallback. So far it looks managable. Looks good. -keith _______________________________________________ Devel mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/devel
