On Mon, Mar 03, 2003 at 08:18:35AM +0100, Matthias Scheler wrote:
>On Sun, Mar 02, 2003 at 11:41:51PM -0500, David Dawes wrote:
>> >"HasShadowPasswd" is only defined in a few files in "xc/config/cf", there
>> >is no default in e.g. "X11.tmpl". But "xc/programs/xdm/Imakefile" and
>> >"xc/programs/xdm/greeter/Imakefile" use it unconditionally like this.
>> >
>> >#if SystemV4 || HasShadowPasswd
>> >PWD_DEFINES = -DUSESHADOW
>> >#endif
>> 
>> While that's strictly speaking OK (it should function correctly),
>
>It does but it causes a warning. It should IMHO look like this ...
>
>#if SystemV4 || (defined(HasShadowPasswd) && HasShadowPasswd)
>PWD_DEFINES = -DUSESHADOW
>#endif
>
>> ... it should really have a default provided in X11.tmpl.
>
>... unless this gets fixed.

I'm committing the default now (to Imake.tmpl).

David
--
David Dawes
Release Engineer/Architect                      The XFree86 Project
www.XFree86.org/~dawes
_______________________________________________
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel

Reply via email to